lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <BANLkTinSueVgV1xyLVo1nycnLm4VJOyTtA@mail.gmail.com>
Date:	Mon, 30 May 2011 00:19:17 +0200
From:	August Lilleaas <august@...ustl.com>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] Firewire: net: replacing deprecated __attribute__((packed))
 with __packed

Forwarding as plain text, mistakenly sent as HTML mail first.

---------- Forwarded message ----------
From: August Lilleaas <august@...ustl.com>
Date: Mon, May 30, 2011 at 12:11 AM
Subject: Re: [PATCH] Firewire: net: replacing deprecated
__attribute__((packed)) with __packed
To: Stefan Richter <stefanr@...6.in-berlin.de>
Cc: linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org


On Sun, May 29, 2011 at 11:44 PM, Stefan Richter
<stefanr@...6.in-berlin.de> wrote:
>
> Who deprecated it and why?

To be frank, the motivation for this patch was a message from
script/checkpatch.pl when scouring random files for warnings. (This is
my first contribution to the kernel.)
Just did some much needed investigation though. It was deprecated for
portability, specifically to avoid GCC specific code. See commit
82ddcb040570411fc2d421d96b3e69711c670328.

>
> Shouldn't you add "#include <linux/compiler.h>" now?

You're right. I'll read up on updating patches and get at it.

>
> --
> Stefan Richter
> -=====-==-== -=-= ===-=
> http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ