linux-kernel - Re: [PATCH] hid: Fix Logitech Driving Force Pro wheel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 May 2011 08:46:59 +0200
From:	Michael Bauer <michael@...auer.org>
To:	linux-input@...r.kernel.org
Cc:	simon@...gewell.org, linux-kernel@...r.kernel.org,
	"Jiri Kosina" <jkosina@...e.cz>
Subject: Re: [PATCH] hid: Fix Logitech Driving Force Pro wheel

Hi Simon,

> > 2). The original does Y then 3 others, the replacement does Y + RZ then 1
> > other.
> 
> OK I missed that you had 'disabled' the first byte value after the hat
> switch (which is presumably the combined acc-brake), in preference for the
> seperate ACC and Brake.
> 
> Is there a reason to prevent the combined acc-brake being reported to the
> system?
> 
> Surely it would be best to report all options so that the app can decide
> which one to use.... I can see that you might want to relabel them for
> consistance with Windows.

Well, i thought about this also and normally i would agree with your 
statement. But my conclusion was to remove the combined axis. Looking at 
Windows all wheel controllers i saw so far have a setting in their driver to 
enable or disable the separate axis. But i never saw a controller which 
provided both separate and combined at the same time. 
I am pretty sure there will be trouble when assigning these controls within an 
application. 
Often the control assignement works like this: User clicks "set axis for 
acceleration", application asks "please move the desired axis" and then 
automatically choses the "moving" axis.
If we report both combined and separate at the same time, the application will 
have a hard time deciding which one to use, as they both will change their 
values.

> Do you know what the 4th (and last) byte value is?
> Simon

No idea - But I never observed any change being reported on this byte, so at 
the moment i assume it is completely unused.

Best regards
Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/