linux-kernel - Re: [PATCH] mm: fix page_lock_anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.1105281738530.14374@sister.anvils>
Date:	Sat, 28 May 2011 17:43:27 -0700 (PDT)
From:	Hugh Dickins <hughd@...gle.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH] mm: fix page_lock_anon_vma leaving mutex locked

On Sat, 28 May 2011, Linus Torvalds wrote:
> On Sat, May 28, 2011 at 5:12 PM, Hugh Dickins <hughd@...gle.com> wrote:
> >
> > Though I think I'm arriving at the conclusion that this patch
> > is correct as is, despite the doubts that have arisen.
> 
> Well, you hopefully saw my second email where I had come to the same conclusion.

Yes, thanks.

> 
> So I applied the third patch as well, after all. I think it's at the
> very least at least "more correct" than what we have now. Whether that
> "page_mapped()" should then be extended to do something else is an
> additional thing, and I suspect it would affect the slow-path case
> too.

Yes, I agree it's certainly more correct (two machines running well
with it for 33 hours now, one of them would hang in 7 or 17 hours).

And I'm increasingly confident that it's complete too, but it will be
interesting to see whether I've persuaded Peter.  It was certainly a
very good point that he raised, that I hadn't thought of at all.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/