linux-kernel - Re: [PATCH v2] arch/tile: add hypervisor-based character driver for SPI flash ROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110529114517.GA13513@suse.de>
Date:	Sun, 29 May 2011 19:45:17 +0800
From:	Greg KH <gregkh@...e.de>
To:	Chris Metcalf <cmetcalf@...era.com>
Cc:	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Eric Biederman <ebiederm@...stanetworks.com>,
	Chris Wright <chrisw@...s-sol.org>,
	Benjamin Thery <benjamin.thery@...l.net>,
	Phil Carmody <ext-phil.2.carmody@...ia.com>
Subject: Re: [PATCH v2] arch/tile: add hypervisor-based character driver for
 SPI flash ROM

On Sat, May 28, 2011 at 08:32:07PM -0400, Chris Metcalf wrote:
> > As you are only using 1 minor device, why not just use a misc device
> > instead?  It's simpler, and you get the sysfs code for free, which you
> > forgot to do, so your device node will never show up in userspace :(
> 
> Interesting; this appears to be a bug.  We use 4 minors (see "srom_devs =
> 4" higher up).  I'll fix this.  We may have some other devices that would
> benefit from being recast as misc devices, so I'll look at our set of
> internal devices.

This kind of implies that you didn't test this code, right?  You might
want to do that next time :)

> Is there a good example of a character device that has multiple minors and
> also is registered with sysfs?

Lots of them, look all over the kernel, and in LDD3 there's even an
outdated example of one I think.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/