linux-kernel - Re: [PATCH] leds: make LEDS_GPIO_REGISTER depend on NEW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTi=F2Gh=+-8ms0nBf+zdLy+7uEOugg@mail.gmail.com>
Date:	Sun, 29 May 2011 09:38:34 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	kernel@...gutronix.de
Subject: Re: [PATCH] leds: make LEDS_GPIO_REGISTER depend on NEW_LEDS

hi Uwe,
> Below is a patch that fixes the layout problem but keeps the
> functionality as before and intended.
>
> -----8<-----
> leds: move LEDS_GPIO_REGISTER out of menuconfig NEW_LEDS
>
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>
> Commit 4440673a "leds: provide helper to register "leds-gpio" devices"
> broke the display of the NEW_LEDS menu as it didn't depend on NEW_LEDS
> and so made "LED drivers" and "LED Triggers" appear at the same level as
> "LED Support" instead of below it as it was before 4440673a.
>
> Moving LEDS_GPIO_REGISTER out of the menuconfig NEW_LEDS fixes this
> unintended side effect.
>
> Reported-by: Axel Lin <axel.lin@...il.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
Your patch looks good.

Thanks,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/