[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BANLkTimsB8Q3bxVc5SY9Rk4ecZYWTnqNmg@mail.gmail.com>
Date: Sun, 29 May 2011 21:37:50 -0400
From: Andrew Lutomirski <luto@....edu>
To: Borislav Petkov <bp@...en8.de>, Andy Lutomirski <luto@....edu>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...e.hu>, x86@...nel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] x86-64: Give vvars their own page
On Sun, May 29, 2011 at 4:34 PM, Borislav Petkov <bp@...en8.de> wrote:
> On Fri, May 27, 2011 at 01:38:39PM -0400, Andy Lutomirski wrote:
>> Move vvars out of the vsyscall page into their own page and mark it
>> NX.
>>
>> Without this patch, an attacker who can force a daemon to call some
>> fixed address could wait until the time contains, say, 0xCD80, and
>> then execute the current time.
>>
>> Signed-off-by: Andy Lutomirski <luto@....edu>
>> ---
>> arch/x86/include/asm/fixmap.h | 1 +
>> arch/x86/include/asm/pgtable_types.h | 2 ++
>> arch/x86/include/asm/vvar.h | 22 ++++++++++------------
>> arch/x86/kernel/vmlinux.lds.S | 27 ++++++++++++++++-----------
>> arch/x86/kernel/vsyscall_64.c | 5 +++++
>> tools/power/x86/turbostat/turbostat | Bin 0 -> 29200 bytes
>
> You've added the turbostat binary to the diffstat too. I believe this
> wasn't your intention, no? :)
Foiled again!
--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists