linux-kernel - RE: [PATCH] 8250_pci: add -ENODEV code for Intel EG20T PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <EC1A82FC0A474852B4C14B0946198E85@hacdom.okisemi.com>
Date:	Mon, 30 May 2011 20:19:40 +0900
From:	"Tomoya MORINAGA" <tomoya-linux@....okisemi.com>
To:	"'Alan Cox'" <alan@...ux.intel.com>, "'Greg KH'" <gregkh@...e.de>
Cc:	<linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
	<qi.wang@...el.com>, <yong.y.wang@...el.com>,
	<joel.clark@...el.com>, <kok.howg.ewe@...el.com>,
	<toshiharu-linux@....okisemi.com>
Subject: RE: [PATCH] 8250_pci: add -ENODEV code for Intel EG20T PCH

Hi Greg

> Because if the PCH driver is not available you want to bind 
> it to the 8250 driver, which also works with it but less efficiently.
> 
> The giant if probably should be a pci match table however
 
Which opinions should I select ?

Though Alan's comment has a point,
IMHO, in probe processing, the efficiently is not so important.
Adding the "#ifdef", I think, readability of 8250_pci.c goes down.

Thanks,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/