linux-kernel - Re: [PATCH] thp: unbalanced parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110530141028.GG19505@random.random>
Date:	Mon, 30 May 2011 16:10:28 +0200
From:	Andrea Arcangeli <aarcange@...hat.com>
To:	Nicolas Kaiser <nikai@...ai.net>
Cc:	Arnd Bergmann <arnd@...db.de>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thp: unbalanced parenthesis

On Mon, May 30, 2011 at 01:02:09PM +0200, Nicolas Kaiser wrote:
> Cc'ed Andrea Arcangeli.
> 
> * Nicolas Kaiser <nikai@...ai.net>:
> > Signed-off-by: Nicolas Kaiser <nikai@...ai.net>
> > ---
> > Untested.
> > 
> >  include/asm-generic/pgtable.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
> > index b4bfe33..b80daee 100644
> > --- a/include/asm-generic/pgtable.h
> > +++ b/include/asm-generic/pgtable.h
> > @@ -88,7 +88,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
> >  	pmd_t pmd = *pmdp;
> >  	pmd_clear(mm, address, pmdp);
> >  	return pmd;
> > -})
> > +}
> >  #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> >  #endif

Reviewed-by: Andrea Arcangeli <aarcange@...hat.com>

All archs supporting THP aren't using that function so it isn't
possible to notice it in any config but it's better to fix it in case
some arch will use it in the future.

Thanks,
Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/