linux-kernel - Re: [PATCH] perf, cgroup: Fix up for new API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110530164653.GA1315@ghc17.ghc.andrew.cmu.edu>
Date:	Mon, 30 May 2011 12:46:53 -0400
From:	Ben Blum <bblum@...rew.cmu.edu>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Stephane Eranian <eranian@...il.com>,
	Ben Blum <bblum@...rew.cmu.edu>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf, cgroup: Fix up for new API

On Mon, May 30, 2011 at 05:00:51PM +0200, Peter Zijlstra wrote:
> Subject: perf, cgroup: Fix up for new API
> From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Date: Mon May 30 16:48:06 CEST 2011
> 
> Ben changed the API but forgot to convert everybody...
> 
> Cc: Ben Blum <bblum@...rew.cmu.edu>
> Cc: Stephane Eranian <eranian@...gle.com>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

Oops - I guess I missed the new subsystem when I refreshed against
2.6.39. This looks good to me.

Acked-by: Ben Blum <bblum@...rew.cmu.edu>

> ---
>  kernel/events/core.c |   22 ++++------------------
>  1 file changed, 4 insertions(+), 18 deletions(-)
> 
> Index: linux-2.6/kernel/events/core.c
> ===================================================================
> --- linux-2.6.orig/kernel/events/core.c
> +++ linux-2.6/kernel/events/core.c
> @@ -7394,26 +7394,12 @@ static int __perf_cgroup_move(void *info
>  	return 0;
>  }
>  
> -static void perf_cgroup_move(struct task_struct *task)
> +static void
> +perf_cgroup_attach_task(struct cgroup *cgrp, struct task_struct *task)
>  {
>  	task_function_call(task, __perf_cgroup_move, task);
>  }
>  
> -static void perf_cgroup_attach(struct cgroup_subsys *ss, struct cgroup *cgrp,
> -		struct cgroup *old_cgrp, struct task_struct *task,
> -		bool threadgroup)
> -{
> -	perf_cgroup_move(task);
> -	if (threadgroup) {
> -		struct task_struct *c;
> -		rcu_read_lock();
> -		list_for_each_entry_rcu(c, &task->thread_group, thread_group) {
> -			perf_cgroup_move(c);
> -		}
> -		rcu_read_unlock();
> -	}
> -}
> -
>  static void perf_cgroup_exit(struct cgroup_subsys *ss, struct cgroup *cgrp,
>  		struct cgroup *old_cgrp, struct task_struct *task)
>  {
> @@ -7425,7 +7411,7 @@ static void perf_cgroup_exit(struct cgro
>  	if (!(task->flags & PF_EXITING))
>  		return;
>  
> -	perf_cgroup_move(task);
> +	perf_cgroup_attach_task(cgrp, task);
>  }
>  
>  struct cgroup_subsys perf_subsys = {
> @@ -7434,6 +7420,6 @@ struct cgroup_subsys perf_subsys = {
>  	.create		= perf_cgroup_create,
>  	.destroy	= perf_cgroup_destroy,
>  	.exit		= perf_cgroup_exit,
> -	.attach		= perf_cgroup_attach,
> +	.attach_task	= perf_cgroup_attach_task,
>  };
>  #endif /* CONFIG_CGROUP_PERF */
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/