linux-kernel - Re: [GIT PATCH] TTY/serial driver patches for .40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 May 2011 00:04:24 +0200
From:	Peter Hüwe <PeterHuewe@....de>
To:	Greg KH <gregkh@...e.de>
Cc:	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Felipe Balbi <balbi@...com>
Subject: Re: [GIT PATCH] TTY/serial driver patches for .40

Am Freitag 27 Mai 2011, 03:00:21 schrieb Greg KH:
> > > Here's the big tty/serial merge for .40
> > 
> > /me confused: this patch
> > 
> > > Felipe Balbi (1):
> > >       tty: make receive_buf() return the amout of bytes received
> > 
> > is more than one year old, which I wouldn't care about, if it didn't
> > introduce a regression on my mackerel
> > (arch/arm/mach-shmobile/board-mackerel.c) board. With it in place
> > printing a lot of text over ssh pauses the output multiple times for
> > several seconds. With this patch reverted the behaviour is back to
> > normal. To reproduce one can either cat a few largish files under /etc
> > or just dmesg - if there have been enough messages accumulated.
> 
> I think I'll be reverting this one.

Hi,

maybe that's related to receive_buf returning an unsigned int, which is 
obviously incompatible with -ENODEV, -EINVAL and the likes, which most of the 
functions now return in case of error.
And unfortunately the return value is unfortunately not checked for errors 
either - so the amount is totally screwed then ;)

See the examples in git
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=b1c43f82c5aa265442f82dba31ce985ebb7aa71c

I could create a patch if desired.

Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/