linux-kernel - Re: [PATCH] hid: Fix Logitech Driving Force Pro wheel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201105300817.15986.michael@m-bauer.org>
Date:	Mon, 30 May 2011 08:17:15 +0200
From:	Michael Bauer <michael@...auer.org>
To:	linux-input@...r.kernel.org
Cc:	simon@...gewell.org, linux-kernel@...r.kernel.org,
	"Jiri Kosina" <jkosina@...e.cz>
Subject: Re: [PATCH] hid: Fix Logitech Driving Force Pro wheel

Hi all,

> Fair enough, I played a little trying to massage the original descriptor
> but could not find a sensible solution - so I guess we'll have to provide
> a full replacement.
Yes, i also spent some time but it does not seem to be possible in a sensible 
way.
 
> I don't see the need to comment the original/replacement blocks, so
> probably a simple 'hex block' would be good.
Fine for me, i will remove it in the next patch.

> Regarding the replacement, you appear to have a lot of unnecessary code
> there. You could try with something like:
> --
> ...
> +0x09, 0x39,         /*          Usage (Hat Switch),             */
> +0x81, 0x42,         /*          Input (Variable),               */
> +0x75, 0x08,         /*          Report Size (8),                */
> +0x95, 0x08,         /*          Report Count (1),               */
> +0x65, 0x00,         /*          Unit,                           */
> +0x06, 0x00, 0xFF,   /*          Usage Page (FF00h),             */
> +0x26, 0xFF, 0x00,   /*          Logical Maximum (255),          */
> +0x46, 0xFF, 0x00,   /*          Physical Maximum (255),         */
> +0x09, 0x01,         /*          Usage (01h),                    */
> +0x81, 0x02,         /*          Input (Variable),               */
> +0xA4,               /*          Push,                           */
> +0x05, 0x01,         /*          Usage Page (Desktop),           */
> +0x95, 0x01,         /*          Report Count (2),               */
> +0x09, 0x31,         /*          Usage (Y),                      */
> +0x09, 0x35,         /*          Usage (Rz),                     */
> +0x81, 0x02,         /*          Input (Variable),               */
> +0xB4,               /*          Pop,                            */
> +0x81, 0x02,         /*          Input (Variable),               */
> +0xC0,               /*      End Collection,                     */
> ...
> --

Good point - didn't think of the Push/Pop commands... 

I will create an updated patch and submit it here again.

Thanks and regards
Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/