linux-kernel - Re: [PATCH 1/1] AT91: flexibity: default leds to heartbeat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110531082800.GE26294@game.jcrosoft.org>
Date:	Tue, 31 May 2011 10:28:00 +0200
From:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To:	Maxim Osipov <maxim.osipov@...il.com>
Cc:	Andrew Victor <linux@...im.org.za>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] AT91: flexibity: default leds to heartbeat

On 18:13 Mon 30 May     , Maxim Osipov wrote:
> This patch changes default behavior of Flexibity board LEDs to blinking
> for boot diagnostic purpose.
> 
> Signed-off-by: Maxim Osipov <maxim.osipov@...il.com>
> ---
>  arch/arm/mach-at91/board-flexibity.c |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/board-flexibity.c b/arch/arm/mach-at91/board-flexibity.c
> index 4fdc96c..8cbec8a 100644
> --- a/arch/arm/mach-at91/board-flexibity.c
> +++ b/arch/arm/mach-at91/board-flexibity.c
> @@ -96,49 +96,49 @@ static struct gpio_led flexibity_leds[] = {
>  		.name			= "usb1:green",
>  		.gpio			= AT91_PIN_PA12,
>  		.active_low		= 1,
> -		.default_trigger	= "default-on",
> +		.default_trigger	= "heartbeat",
can we factorize this a few
they have all the same default_trigger and active low

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/