linux-kernel - Re: [PATCH 2/3] irq: handle spurios irq detection for threaded irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 May 2011 12:35:14 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] irq: handle spurios irq detection for threaded
 irqs

On Tue, 31 May 2011, Sebastian Andrzej Siewior wrote:
>  			raw_spin_unlock_irq(&desc->lock);
> -			handler_fn(desc, action);
> +			action_ret = handler_fn(desc, action);
> +			if (!noirqdebug) {
> +				raw_spin_lock_irq(&desc->lock);

Hmm. This will deadlock in __report_bad_irq().

> +				note_interrupt(action->irq, desc, action_ret);
> +				raw_spin_unlock_irq(&desc->lock);
> +			}

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/