linux-kernel - Re: [PATCH] Fix corruption of CONFIG_X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 May 2011 12:41:06 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Ted Ts'o <tytso@....edu>, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Alexey Dobriyan <adobriyan@...il.com>,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH] Fix corruption of CONFIG_X86_32 in 'make oldconfig'

* David Woodhouse <dwmw2@...radead.org> wrote:

> On Tue, 2011-05-31 at 09:53 +0200, Ingo Molnar wrote:
> > I'll always prefer typing:
> >   make ARCH=x86_64 ...
> > To:
> >   make ARCH=x86 CONFIG_64BIT=y ...
> 
> Why else would you need to specify ARCH=x86 on the latter command line? 

Note that if we are consistent and implement the logical extension of 
your CONFIG_64BIT 'fix' then we could pick up the target architecture 
from the .config as well and not use the host architecture.

The very same arguments apply: the user provided an ARCH=arm .config, 
why does 'make oldconfig' switch it to x86_64 automatically?

Also, i prefer to type out the architecture due to:

 | [ Btw., 'override the architecture' usecase is not just theoretical:
 |  i sometimes use this form to convert existing .config's *between*
 |  architectures, not just from 32-bit to 64-bit. So if i get an ARM
 |  bugreport that gives me the appearance of a core kernel bug i will
 |  often start by converting that to an x86 .config via 'make
 |  ARCH=x86_64 oldconfig'. ]

But even if we leave out the 'ARCH=x86' portion, which ones are the 
two shortest commands to type, in your opinion:

	make ARCH=i386
	make ARCH=x86_64
	make CONFIG_64BIT=y

?

> You're not building on an x86 box? I always suspected you had some 
> alien technology! Does it run Linux?

Could you please stop with this borderline taunting tone?

You've been wrong so many times in this thread that i think toning 
down some of your shouting in favor of a bit more listening would be 
well advised ...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/