linux-kernel - Re: [PATCH 2/2] staging/iio: Make IIO depend on GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8eace637-27d2-41c5-bcbd-0087d6c75a75@email.android.com>
Date:	Tue, 31 May 2011 12:01:06 +0100
From:	"jonathan.cameron@...il.com" <jic23@....ac.uk>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Jeff Mahoney <jeffm@...e.com>
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging/iio: Make IIO depend on GENERIC_HARDIRQS



Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

>On m68k (which doesn't support generic hardirqs yet):
>
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_trigger_poll’:
>drivers/staging/iio/industrialio-trigger.c:180: error: implicit
>declaration of function ‘generic_handle_irq’
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_trigger_poll_chained’:
>drivers/staging/iio/industrialio-trigger.c:200: error: implicit
>declaration of function ‘handle_nested_irq’
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_trig_release’:
>drivers/staging/iio/industrialio-trigger.c:379: error: implicit
>declaration of function ‘irq_modify_status’
>drivers/staging/iio/industrialio-trigger.c:382: error: implicit
>declaration of function ‘irq_set_chip’
>drivers/staging/iio/industrialio-trigger.c:384: error: implicit
>declaration of function ‘irq_set_handler’
>drivers/staging/iio/industrialio-trigger.c:388: error: implicit
>declaration of function ‘irq_free_descs’
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_trig_subirqmask’:
>drivers/staging/iio/industrialio-trigger.c:402: error: implicit
>declaration of function ‘irq_data_get_irq_chip’
>drivers/staging/iio/industrialio-trigger.c:402: warning: initialization
>makes pointer from integer without a cast
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_trig_subirqunmask’:
>drivers/staging/iio/industrialio-trigger.c:411: warning: initialization
>makes pointer from integer without a cast
>drivers/staging/iio/industrialio-trigger.c: In function
>‘iio_allocate_trigger’:
>drivers/staging/iio/industrialio-trigger.c:432: error: implicit
>declaration of function ‘irq_alloc_descs’
>drivers/staging/iio/industrialio-trigger.c:455: error:
>‘handle_simple_irq’ undeclared (first use in this function)
>drivers/staging/iio/industrialio-trigger.c:455: error: (Each undeclared
>identifier is reported only once
>drivers/staging/iio/industrialio-trigger.c:455: error: for each
>function it appears in.)
>
>Hence IIO_TRIGGER should depend on GENERIC_HARDIRQS.
>But as IIO_TRIGGER and IIO_RING_BUFFER form a maze of dependencies and
>selects,
>just make the whole IIO subsystem depend on GENERIC_HARDIRQS.
>
>This dependency also covers !S390, so that one can be removed again.
Dratt  We talked about this and thought S390 was the only non generic hard irq left.  Should have played safe sorry!
>Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Acked-by: Jonathan Cameron <jic23@....ac.uk>
>---
> drivers/staging/iio/Kconfig |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
>index f96d5b5..d329635 100644
>--- a/drivers/staging/iio/Kconfig
>+++ b/drivers/staging/iio/Kconfig
>@@ -4,7 +4,7 @@
> 
> menuconfig IIO
> 	tristate "Industrial I/O support"
>-	depends on !S390
>+	depends on GENERIC_HARDIRQS
> 	help
> 	  The industrial I/O subsystem provides a unified framework for
> 	  drivers for many different types of embedded sensors using a
>-- 
>1.7.0.4

-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/