linux-kernel - Re: [PATCH] Fix corruption of CONFIG_X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 May 2011 15:56:27 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Ted Ts'o <tytso@....edu>, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Alexey Dobriyan <adobriyan@...il.com>,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH] Fix corruption of CONFIG_X86_32 in 'make oldconfig'


* David Woodhouse <dwmw2@...radead.org> wrote:

> On Tue, 2011-05-31 at 14:45 +0200, Ingo Molnar wrote:
> > * David Woodhouse <dwmw2@...radead.org> wrote:
> > 
> > > > Also, i prefer to type out the architecture due to:
> > > >  |                                              ...So if i get an ARM
> > > >  |  bugreport that gives me the appearance of a core kernel bug i will
> > > >  |  often start by converting that to an x86 .config via 'make
> > > >  |  ARCH=x86_64 oldconfig'. ]
> > > 
> > > So first you point out that it's automatic, and then you still specify
> > > it manually?
> > 
> > Currently it's not automatic so i prefer to type it out.
> 
> No, you were right the first time. It *is* automatic.

The architecture *inside* the .config is not inherited automatically 
but overriden by the host architecture, so due to this assymetry i 
prefer to use explicit ARCH=xxx lines whenever i deal with configs.

> >     "I believe that this 'filtered randconfig' behaviour is now fairly much
> >      the *only* use for the old 'ARCH=i386' and 'ARCH=x86_64'."
> > 
> > You are wrong again - it isnt, as me and others pointed it out.
> 
> Not *so* wrong that all those other use cases couldn't be addressed 
> in the same, simple patch to allow CONFIG_FOO on the 'make' command 
> line.

So "partially wrong" is not wrong? Indeed, if defined that way then i 
agree that you must almost never be wrong ;-)

Really, i have little interest in continuing the 'who was wrong' 
angle of this discussion - i think people can read and i think people 
have made it rather clear what they are using and why, and what 
they'd like to see continue work, which requirements i'll try to 
apply to related patches you send. The last version of your patch 
looked good at first sight, except the changelog.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/