linux-kernel - [PATCH] genirq: fix descriptor init on non-sparse IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1306858479-16622-1-git-send-email-linus.walleij@stericsson.com>
Date:	Tue, 31 May 2011 18:14:39 +0200
From:	Linus Walleij <linus.walleij@...ricsson.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	<linux-kernel@...r.kernel.org>
Cc:	Jonathan Cameron <jic23@....ac.uk>,
	Lee Jones <lee.jones@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: [PATCH] genirq: fix descriptor init on non-sparse IRQs

From: Linus Walleij <linus.walleij@...aro.org>

The genirq changes are initializing descriptors for sparse IRQs
quite differently from how non-sparse (stacked?) IRQs are
initialized, with the effect that on my platform all IRQs are
default-disabled on sparse IRQs and default-enabled if non-sparse
IRQs are used, crashing some GPIO driver.

Fix this by refactoring the non-sparse IRQs to use the same
descriptor init function as the sparse IRQs. Tested on Ux500.

Signed-off: Linus Walleij <linus.walleij@...aro.org>
---
 kernel/irq/irqdesc.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 886e803..c7ddc87 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -257,13 +257,11 @@ int __init early_irq_init(void)
 	count = ARRAY_SIZE(irq_desc);
 
 	for (i = 0; i < count; i++) {
-		desc[i].irq_data.irq = i;
-		desc[i].irq_data.chip = &no_irq_chip;
 		desc[i].kstat_irqs = alloc_percpu(unsigned int);
-		irq_settings_clr_and_set(desc, ~0, _IRQ_DEFAULT_INIT_FLAGS);
-		alloc_masks(desc + i, GFP_KERNEL, node);
-		desc_smp_init(desc + i, node);
+		alloc_masks(&desc[i], GFP_KERNEL, node);
+		raw_spin_lock_init(&desc[i].lock);
 		lockdep_set_class(&desc[i].lock, &irq_desc_lock_class);
+		desc_set_defaults(i, &desc[i], node);
 	}
 	return arch_early_irq_init();
 }
-- 
1.7.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/