lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 31 May 2011 05:26:24 +0200
From:	Mike Galbraith <efault@....de>
To:	Hillf Danton <dhillf@...il.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Yong Zhang <yong.zhang0@...il.com>
Subject: Re: [PATCH] sched: fix need_resched() when checking peempt

On Tue, 2011-05-24 at 21:50 +0800, Hillf Danton wrote:
> On Tue, May 24, 2011 at 9:39 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> > On Tue, 2011-05-24 at 21:27 +0800, Hillf Danton wrote:
> >> When checking if current task could be preempted by a newly woken task,
> >> further check could be bypassed if the current thread is different from
> >> the current task of run-queue, and it is corrected accordingly.
> >
> > Ug, that change log is an obfuscated mess. But looking at the actual
> > patch, I figured what you wanted to say. How about this:
> >
> > ----
> > The RT preempt check tests the wrong task if NEED_RESCHED is set. It
> > currently checks the local CPU task. It is suppose to check the task
> > that is running on the run queue we are about to wake another task on.
> > ----
> >
> Thanks, it is great changelog:)

Has this been queued, or is it awaiting re-submission?

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists