linux-kernel - Re: [PATCH 1/4] Cache xattr security drop check for write v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110531201834.GB27166@one.firstfloor.org>
Date:	Tue, 31 May 2011 22:18:34 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Steven Whitehouse <swhiteho@...hat.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, chris.mason@...cle.com,
	josef@...hat.com, agruen@...bit.com,
	"Serge E. Hallyn" <serue@...ibm.com>
Subject: Re: [PATCH 1/4] Cache xattr security drop check for write v2

On Tue, May 31, 2011 at 09:07:50PM +0100, Al Viro wrote:
> On Tue, May 31, 2011 at 07:42:26PM +0100, Steven Whitehouse wrote:
> 
> > Yes, it should test for xattr too,
> 
> Frankly, I suspect that the sanest way to handle that is this:
> 	* new superblock flag - MS_NOSEC
> 	* S_NOSEC is never set unless we have MS_NOSEC
> 	* mount_bdev() sets it before calling fill_super callback.
> 	* ocfs2 and fuse *clear* it in their fill_super

gfs2 needs to clear it too (unless Steven's updated patch goes in too)
Steven?

> 	* btrfs manually sets it in its ->mount()

Looks good. I haven't test it so far though.

Acked-by: Andi Kleen <ak@...ux.intel.com>

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/