linux-kernel - Re: [PATCH 2/2] atomic: move atomic_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTi=Tg=t5LrnvR2Sn08K0Ktm8ZKNCCA@mail.gmail.com>
Date:	Tue, 31 May 2011 16:21:12 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Arun Sharma <asharma@...com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...l.org>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH 2/2] atomic: move atomic_add_unless to generic code

On Tue, May 31, 2011 at 15:10, Arun Sharma wrote:
> This is in preparation for more generic atomic
> primitives based on __atomic_add_unless.

i think you might have to have those primitives in place before this
patch makes sense.  the only thing this does is hoist a single
comparison out of arch atomic.h's and into linux/atomic.h.  this
savings alone looks simply like over engineering to me.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/