linux-kernel - Re: [PATCH 2/2] ide-cd: Fix another signedness warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110531.152445.44639723.davem@davemloft.net>
Date:	Tue, 31 May 2011 15:24:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cmdkhh@...il.com
Cc:	bp@...en8.de, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ide-cd: Fix another signedness warning

From: Connor Hansen <cmdkhh@...il.com>
Date: Mon, 30 May 2011 00:26:58 -0700

> One of the legit warnings 'make W=3 drivers/ide/ide-cd.o generates is
> 
> drivers/ide/ide-cd.c: In function ide_cd_queue_pc:
> drivers/ide/ide-cd.c:451:3: warning: conversion to unsigned int from
>       int may change the sign of the result
> 
> timeout is passed as an int, but is declared as an unsigned int in
> struct request in include/linux/blkdev.h
> 
> Signed-off-by: Connor Hansen <cmdkhh@...il.com>

This is beyond academic and may in fact introduce strange things.

All except one call site passes "0" for the timeout.

And that one call site passes packet_command->timeout from userspace
which is an 'int'.

I'm not applying this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/