linux-kernel - Re: [PATCH] staging: intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 1 Jun 2011 01:42:12 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Andre Bartke <andre.bartke@...glemail.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	Andre Bartke <andre.bartke@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: intel_sst: Fix memory leak

On Tue, May 31, 2011 at 09:03:56PM +0200, Andre Bartke wrote:
> In case of an error stream_bufs is not freed here.
> 
> Signed-off-by: Andre Bartke <andre.bartke@...il.com>
> ---
>  .../staging/intel_sst/intel_sst_app_interface.c    |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/intel_sst/intel_sst_app_interface.c b/drivers/staging/intel_sst/intel_sst_app_interface.c
> index b8c7ddb..93b41a2 100644
> --- a/drivers/staging/intel_sst/intel_sst_app_interface.c
> +++ b/drivers/staging/intel_sst/intel_sst_app_interface.c
> @@ -430,8 +430,10 @@ static int snd_sst_fill_kernel_list(struct stream_info *stream,
>  				return -ENOMEM;
>  			if (copy_from_user((void *) &rar_handle,
>  					iovec[index].iov_base,
> -					sizeof(__u32)))
> +					sizeof(__u32))) {
> +				kfree(stream_bufs);
>  				return -EFAULT;
> +			}
>  			stream_bufs->addr = (char *)rar_handle;


Btw, the original code looks seems pretty awful.  "rar_handle" is
a kernel pointer that we get from user space.  It is a u32 type so
this won't work under a 64 bit OS.

These allocations get added to a list.  Maybe we should free them
all?  It's hard to say.  There is only one place that calls this
function, and it ignores the return value.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/