linux-kernel - Re: [PATCH] init, calibrate: Drop annoying warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimZ4xUEW1ZSZ7eQ9A9SdtBh6MjdDQ@mail.gmail.com>
Date:	Wed, 1 Jun 2011 09:04:59 +1000
From:	Andrew Worsley <amworsley@...il.com>
To:	Borislav Petkov <bp@...64.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Phil Carmody <ext-phil.2.carmody@...ia.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <borislav.petkov@....com>
Subject: Re: [PATCH] init, calibrate: Drop annoying warning

I can see your point - it's useful when debugging the bogomips issue -
but if it's working it's not relevant.
Would be nice to have an extra level of verbose debug or a debug
branch of the file or perhaps just a relevant comment
that would easily allow it to be found and reverted to re-enable debug
if people want to debug this stuff again.

That said I would suggest just changing the comment (I don't know how
to just submit a comment change?) to something like:

"Drop calibrate_delay_direct() KERN_DEBUG printk related to bogomips
calculation as it appears when booting
every core on setups with 'ignore_loglevel' for people who want to
test latest kernels and scan dmesg for possible issues.
and this information isn't very useful to the widest audience of
kernel boot message gazers."

which would allow an easy revert locally when ever it was deemed useful.

On 1 June 2011 04:29, Borislav Petkov <bp@...64.org> wrote:
> From: Borislav Petkov <borislav.petkov@....com>
>
> Even though the error message is KERN_DEBUG, it appears when booting
> every core on setups with 'ignore_loglevel' for people who want to test
> latest kernels and scan dmesg for possible issues. Also, it doesn't show
> very useful information to the widest audience of kernel boot message
> gazers so drop it.
>
> Introduced by d2b463135f84d15808163cd15638b108e323d3e7.
>
> Signed-off-by: Borislav Petkov <borislav.petkov@....com>
> ---
>  init/calibrate.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/init/calibrate.c b/init/calibrate.c
> index cfd7000..2568d22 100644
> --- a/init/calibrate.c
> +++ b/init/calibrate.c
> @@ -93,9 +93,6 @@ static unsigned long __cpuinit calibrate_delay_direct(void)
>                 * If the upper limit and lower limit of the timer_rate is
>                 * >= 12.5% apart, redo calibration.
>                 */
> -               printk(KERN_DEBUG "calibrate_delay_direct() timer_rate_max=%lu "
> -                           "timer_rate_min=%lu pre_start=%lu pre_end=%lu\n",
> -                         timer_rate_max, timer_rate_min, pre_start, pre_end);
>                if (start >= post_end)
>                        printk(KERN_NOTICE "calibrate_delay_direct() ignoring "
>                                        "timer_rate as we had a TSC wrap around"
> --
> 1.7.4.rc2
>
>

Hopefully the code is working and the KERN_NOTICE is considered useful
to indicate to people it recovering from the problem on other machines
besides my own.

Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/