linux-kernel - Re: [PATCH v2] crypto: sha1: modify sha1_update to use SHA1_BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110531052245.GA17068@gondor.apana.org.au>
Date:	Tue, 31 May 2011 15:22:45 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Mandeep Singh Baines <msb@...omium.org>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2] crypto: sha1: modify sha1_update to use
	SHA1_BLOCK_SIZE

On Thu, May 26, 2011 at 04:20:58PM -0700, Mandeep Singh Baines wrote:
> David Miller (davem@...emloft.net) wrote:
> > 
> > The temp[] buffer is explicitly places inside the inner most
> > basic block so that the compiler doesn't allocate the stack
> > space unless that code path is taken.
> > 
> 
> Fixed in V2 (this patch). Thanks for the review.
> 
> -- >8 -- (snip)
> 
> Plus some other minor cleanup.

I don't really like the cleanups.  In any case, mixing up the
use of SHA1_BLOCK_SIZE with cleanups increases the chance of
introducing a bug.

So please redo the patch with only the addition of SHA1_BLOCK_SIZE
and nothing else.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/