linux-kernel - Re: [026/146] block: dont block events on excl write for non-optical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DE6034C.4020808@fusionio.com>
Date:	Wed, 1 Jun 2011 11:15:56 +0200
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Greg KH <gregkh@...e.de>
CC:	Tejun Heo <tj@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...nel.org" <stable@...nel.org>,
	"stable-review@...nel.org" <stable-review@...nel.org>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"alan@...rguk.ukuu.org.uk" <alan@...rguk.ukuu.org.uk>
Subject: Re: [026/146] block: dont block events on excl write for non-optical

On 2011-06-01 10:58, Greg KH wrote:
> On Wed, Jun 01, 2011 at 05:15:14PM +0900, Tejun Heo wrote:
>> Hello, Greg.
>>
>> On Wed, Jun 01, 2011 at 04:59:22PM +0900, Greg KH wrote:
>>> 2.6.38-stable review patch.  If anyone has any objections, please let us know.
>>>
>>> ------------------
>>>  devices
>>>
>>> From: Tejun Heo <tj@...nel.org>
>>>
>>> commit d4dc210f69bcb0b4bef5a83b1c323817be89bad1 upstream.
>>>
>>> Disk event code automatically blocks events on excl write.  This is
>>> primarily to avoid issuing polling commands while burning is in
>>> progress.  This behavior doesn't fit other types of devices with
>>> removeable media where polling commands don't have adverse side
>>> effects and door locking usually doesn't exist.
>>>
>>> This patch introduces new genhd flag which controls the auto-blocking
>>> behavior and uses it to enable auto-blocking only on optical devices.
>>>
>>> Note for stable: 2.6.38 and later only
>>
>> This one should be accompanied by the following commit which is
>> currently in Jens' tree and will soon be pulled into Linus' tree.
>> Sorry about the fuss.  ->check_events() update turned out to be much
>> more fragile than I originally expected.  :(
>>
>> commit 4c49ff3fe128ca68dabd07537415c419ad7f82f9
>> Author: Tejun Heo <tj@...nel.org>
>> Date:   Wed Jun 1 08:27:41 2011 +0200
>>
>>     block: blkdev_get() should access ->bd_disk only after success
> 
> As I can't take it into -stable until it hits Linus's tree, I'll have to
> wait until then.  Hopefully it hits there soon, I'll watch out for it.
> 
> thanks for letting me know.

It'll go out in the next few days. The above commit also references this
patch, so you should have proper notification when it goes in.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/