lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Jun 2011 12:14:40 +0200 (CEST) From: Thomas Gleixner <tglx@...utronix.de> To: Geert Uytterhoeven <geert@...ux-m68k.org> cc: Linux/PPC Development <linuxppc-dev@...ts.ozlabs.org>, Linux Kernel Development <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] powerpc/fsl: Use irq_data_get_irq_handler_data() in chain handler On Wed, 1 Jun 2011, Geert Uytterhoeven wrote: > If you already have a pointer to a struct irq_data , it's more efficient > to use irq_data_get_irq_handler_data(). > irq_get_handler_data() has to look up the struct irq_desc pointer again, > which was already passed to the chain handler. > > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org> > --- > Completely untested, not even compile-tested. > If this is correct, there are probably more of these? > > arch/powerpc/sysdev/fsl_msi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c > index 92e7833..9b92c82 100644 > --- a/arch/powerpc/sysdev/fsl_msi.c > +++ b/arch/powerpc/sysdev/fsl_msi.c > @@ -193,7 +193,7 @@ static void fsl_msi_cascade(unsigned int irq, struct irq_desc *desc) > u32 have_shift = 0; > struct fsl_msi_cascade_data *cascade_data; > > - cascade_data = irq_get_handler_data(irq); > + cascade_data = irq_data_get_irq_handler_data(idata); cascade_data = irq_desc_get_handler_data(desc); Might compile and work :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists