[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201106011554.53090.peter.ujfalusi@ti.com>
Date: Wed, 1 Jun 2011 15:54:52 +0300
From: Peter Ujfalusi <peter.ujfalusi@...com>
To: Tony Lindgren <tony@...mide.com>
CC: "Girdwood, Liam" <lrg@...com>,
Mark Brown <broonie@...nsource.wolfsonmicro.com>,
Samuel Ortiz <sameo@...ux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH 3/8] MFD: twl4030-audio: Rename platform data
On Wednesday 01 June 2011 15:07:54 Tony Lindgren wrote:
>
> Can you please take a look at creating arch/arm/mach-omap2/i2c-twl.c or
> something in common-board-devices.c to get rid of the cut and paste
> duplication in every board-*.c file?
Yes, it would make sense, since most of the board has similar configuration,
and we have lots of duplicated code around.
> Maybe you could have a generic twl_init function that allows overriding
> things like keypad with board specific configuration?
We might need also support for overriding other configurations
(audio/codec/vibra for sure needs that).
I'll take a look, but I think it is not going to be part of v2 of this series.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists