linux-kernel - Re: [PATCH 7/14] drm/i915: adjust to new truncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.1106011002420.23468@sister.anvils>
Date:	Wed, 1 Jun 2011 10:04:00 -0700 (PDT)
From:	Hugh Dickins <hughd@...gle.com>
To:	Christoph Hellwig <hch@...radead.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Wilson <chris@...is-wilson.co.uk>,
	Keith Packard <keithp@...thp.com>,
	Dave Airlie <airlied@...hat.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH 7/14] drm/i915: adjust to new truncate_range

On Tue, 31 May 2011, Christoph Hellwig wrote:

> >  	/* Our goal here is to return as much of the memory as
> >  	 * is possible back to the system as we are called from OOM.
> >  	 * To do this we must instruct the shmfs to drop all of its
> > -	 * backing pages, *now*. Here we mirror the actions taken
> > -	 * when by shmem_delete_inode() to release the backing store.
> > +	 * backing pages, *now*.
> >  	 */
> >  	inode = obj->base.filp->f_path.dentry->d_inode;
> > -	truncate_inode_pages(inode->i_mapping, 0);
> >  	if (inode->i_op->truncate_range)
> >  		inode->i_op->truncate_range(inode, 0, (loff_t)-1);
> > +	else
> > +		truncate_inode_pages(inode->i_mapping, 0);
> 
> Given that it relies on beeing on shmemfs it should just call it
> directly.

As agreed in other mail, I'll do a v2 series in a few days,
making that change - thanks.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/