linux-kernel - Re: [PATCH 1/10] drivers/char/hw_random/omap-rng.c: add missing clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1306948814.4204.572.camel@calx>
Date:	Wed, 01 Jun 2011 12:20:14 -0500
From:	Matt Mackall <mpm@...enic.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	Deepak Saxena <dsaxena@...xity.net>,
	kernel-janitors@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/10] drivers/char/hw_random/omap-rng.c: add missing
 clk_put

On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> Convert a return to a jump to an existing label that calls clk_put.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r exists@
> expression e1,e2;
> statement S;
> @@
> 
> e1 = clk_get@p1(...);
> ... when != e1 = e2
>     when != clk_put(e1)
>     when any
> if (...) { ... when != clk_put(e1)
>                when != if (...) { ... clk_put(e1) ... }
> * return@p3 ...;
>  } else S
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>

That's impressive.

Signed-off-by: Matt Mackall <mpm@...enic.com>

> ---
>  drivers/char/hw_random/omap-rng.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
> index 2cc755a..b757fac 100644
> --- a/drivers/char/hw_random/omap-rng.c
> +++ b/drivers/char/hw_random/omap-rng.c
> @@ -113,8 +113,10 @@ static int __devinit omap_rng_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  
> -	if (!res)
> -		return -ENOENT;
> +	if (!res) {
> +		ret = -ENOENT;
> +		goto err_region;
> +	}
>  
>  	if (!request_mem_region(res->start, resource_size(res), pdev->name)) {
>  		ret = -EBUSY;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
Mathematics is the supreme nostalgia of our time.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/