linux-kernel - Re: [PATCH] x86 pci acpi: fix type mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 1 Jun 2011 11:51:15 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Németh Márton <nm127@...email.hu>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Bjorn Helgaas <bjorn.helgaas@...com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Julia Lawall <julia@...u.dk>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86 pci acpi: fix type mismatch

On Sat, 14 May 2011 19:27:33 +0200
Németh Márton <nm127@...email.hu> wrote:

> From: Márton Németh <nm127@...email.hu>
> 
> The flags field of struct resource from linux/ioport.h is "unsigned long". Change
> the "type" parameter of coalesce_windows() function to match that field. This fixes
> the following warning messages when compiling with "make C=1 W=1 bzImage modules":
> 
> arch/x86/pci/acpi.c: In function ‘coalesce_windows’:
> arch/x86/pci/acpi.c:198: warning: conversion to ‘long unsigned int’ from ‘int’ may change the sign of the result
> arch/x86/pci/acpi.c:203: warning: conversion to ‘long unsigned int’ from ‘int’ may change the sign of the result
> 
> Signed-off-by: Márton Németh <nm127@...email.hu>
> ---
> --- linux-2.6.39-rc6/arch/x86/pci/acpi.c.orig	2011-05-04 04:59:13.000000000 +0200
> +++ linux-2.6.39-rc6/arch/x86/pci/acpi.c	2011-05-14 19:12:42.000000000 +0200
> @@ -188,7 +188,7 @@ static bool resource_contains(struct res
>  	return false;
>  }
> 
> -static void coalesce_windows(struct pci_root_info *info, int type)
> +static void coalesce_windows(struct pci_root_info *info, unsigned long type)
>  {
>  	int i, j;
>  	struct resource *res1, *res2;

Applied to my for-linus tree, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/