linux-kernel - Re: [PATCH 4/6] MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110602090509.GB7800@elte.hu>
Date:	Thu, 2 Jun 2011 11:05:09 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Subject: Re: [PATCH 4/6] MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern


* Joe Perches <joe@...ches.com> wrote:

> On Thu, 2011-06-02 at 09:40 +0200, Ingo Molnar wrote:
> > * Joe Perches <joe@...ches.com> wrote:
> > > No arch/*/lib/perf_event* files exist so remove the pattern.
> > The arch/*/lib/ hierarchy is a common place to put stuff into, it 
> > does not hurt at all to have it mentioned.
> 
> Every once in awhile I run a script on MAINTAINERS
> and fix up defects found by the script.
>
> Dead code is dead code.
> This was unused as of commit e360adbe2924.

NAK, i've outlined my reasons:

 - It's an obvious pattern to put librarized functionality in there
   and should an architecture grow a file there in the future it
   will be included automatically.

 - What we are interested in are false positives (files included that
   should not be matched) and false negatives (files belonging to a
   subsystm not included) - this pattern is none of those.

> > stop mucking with these patterns and start dealing with some of 
> > the more important problems we have?
> 
> My time, my choice on what to do with it.

Yes, but this time you are also wasting my time with such a stupid 
patch, so it's not just your time wasted anymore.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/