linux-kernel - Re: [PATCH] VLYNQ: vlynq_enable_device should try remote enabling first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 2 Jun 2011 15:46:37 +0200
From:	Florian Fainelli <florian@...nwrt.org>
To:	linux-kernel@...r.kernel.org
Cc:	akpm@...ux-foundation.org
Subject: Re: [PATCH] VLYNQ: vlynq_enable_device should try remote enabling first

Andrew,

On Friday 11 March 2011 11:57:28 Florian Fainelli wrote:
> I noticed device lockups on TNETD7200 chips when vlynq_enable_device tried
> enabling the device in the following order: external -> local -> remote
> 
> inverting the external and remote order fixes the lock up and allows normal
> operation of the remote VLYNQ device on all TNETD generations (7100, 7200,
> 7300).
> 
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>

I did not get a feedback from you whether you applied this patch or not, it is
still valid though.

Thank you.

> ---
> diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> index f885c86..0dd05ce 100644
> --- a/drivers/vlynq/vlynq.c
> +++ b/drivers/vlynq/vlynq.c
> @@ -516,9 +516,9 @@ static int __vlynq_enable_device(struct vlynq_device
> *dev) !__vlynq_try_external(dev))
>  				return 0;
>  		} else {
> -			if (!__vlynq_try_external(dev) ||
> -				!__vlynq_try_local(dev)    ||
> -				!__vlynq_try_remote(dev))
> +			if (!__vlynq_try_remote(dev) ||
> +				!__vlynq_try_local(dev)  ||
> +				!__vlynq_try_external(dev))
>  				return 0;
>  		}
>  		break;
> --
> 1.7.1

-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/