linux-kernel - Re: [PATCH] leds: fix the menuconfig being wrongly displayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 3 Jun 2011 00:10:14 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Valdis.Kletnieks@...edu
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH] leds: fix the menuconfig being wrongly displayed

On Thu, Jun 2, 2011 at 8:57 PM,  <Valdis.Kletnieks@...edu> wrote:
> On Thu, 02 Jun 2011 13:09:14 +0800, Eric Miao said:
>> From: Eric Miao <eric.miao@...onical.com>
>>
>> Seems when a config option does not have a dependency of the menuconfig,
>> it messes the display of the rest configs, even if it's a hidden one.
>>
>> Signed-off-by: Eric Miao <eric.y.miao@...il.com>
>> Cc: Richard Purdie <rpurdie@...ys.net>
>> ---
>>  drivers/leds/Kconfig |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> index 23f0d5e..7066820 100644
>> --- a/drivers/leds/Kconfig
>> +++ b/drivers/leds/Kconfig
>> @@ -7,6 +7,8 @@ menuconfig NEW_LEDS
>>         This is not related to standard keyboard LEDs which are controlled
>>         via the input system.
>>
>> +if NEW_LEDS
>> +
>>  config LEDS_CLASS
>>       bool "LED Class Support"
>>       depends on NEW_LEDS
>
> Having added that 'if', do we still need that 'depends'?
>

I don't think so. We can definitely remove it. Updated as follows:

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 23f0d5e..1251e6a 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -7,9 +7,10 @@ menuconfig NEW_LEDS
          This is not related to standard keyboard LEDs which are controlled
          via the input system.

+if NEW_LEDS
+
 config LEDS_CLASS
        bool "LED Class Support"
-       depends on NEW_LEDS
        help
          This option enables the led sysfs class in /sys/class/leds.  You'll
          need this to do anything useful with LEDs.  If unsure, say N.
@@ -21,8 +22,6 @@ config LEDS_GPIO_REGISTER
          As this function is used by arch code it must not be compiled as a
          module.

-if NEW_LEDS
-
 comment "LED drivers"

 config LEDS_88PM860X
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/