linux-kernel - Re: [PATCH] ksm: fix race between ksmd and exiting task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110602212348.GM23047@sequoia.sous-sol.org>
Date:	Thu, 2 Jun 2011 14:23:48 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Andrea Righi <andrea@...terlinux.com>
Cc:	Chris Wright <chrisw@...s-sol.org>, CAI Qian <caiqian@...hat.com>,
	Hugh Dickins <hughd@...gle.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mel@....ul.ie>,
	Izik Eidus <ieidus@...hat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] ksm: fix race between ksmd and exiting task

* Andrea Righi (andrea@...terlinux.com) wrote:
> On Thu, Jun 02, 2011 at 10:35:49AM -0700, Chris Wright wrote:
> > Andrea Righi reported a case where an exiting task can race against
> > ksmd.
> > 
> > ksm_scan.mm_slot == the only registered mm
> > CPU 1 (bug program)		CPU 2 (ksmd)
> >  				list_empty() is false
> > lock
> > ksm_scan.mm_slot
> > list_del
> > unlock
> >  				slot == &ksm_mm_head (but list is now empty_)
> > 
> > Close this race by revalidating that the new slot is not simply the list
> > head again.
> 
> I confirm this fixes the problem on my side.
> 
> Tested-by: Andrea Righi <andrea@...terlinux.com>

Great, thanks for verifying.

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/