| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110602154754.142920c6@notabene.brown> Date: Thu, 2 Jun 2011 15:47:54 +1000 From: NeilBrown <neilb@...e.de> To: Namhyung Kim <namhyung@...il.com> Cc: linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] md: convert double atomic_inc() to atomic_add() On Thu, 2 Jun 2011 13:53:02 +0900 Namhyung Kim <namhyung@...il.com> wrote: > Signed-off-by: Namhyung Kim <namhyung@...il.com> > --- > drivers/md/md.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/md.c b/drivers/md/md.c > index aa640a85bb21..f210e42a56ca 100644 > --- a/drivers/md/md.c > +++ b/drivers/md/md.c > @@ -396,8 +396,7 @@ static void submit_flushes(struct work_struct *ws) > * we reclaim rcu_read_lock > */ > struct bio *bi; > - atomic_inc(&rdev->nr_pending); > - atomic_inc(&rdev->nr_pending); > + atomic_add(2, &rdev->nr_pending); > rcu_read_unlock(); > bi = bio_alloc_mddev(GFP_KERNEL, 0, mddev); > bi->bi_end_io = md_end_flush; Thanks, but I don't think I want this patch. I'm happy having two separate 'atomic_inc' calls. I think it makes it a bit clearer what is happening, and it is easier to search for all atomic_inc calls. NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists