linux-kernel - Re: [PATCH 4/10] drivers/net/can/flexcan.c: add missing clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110602.001059.183111215741236866.davem@davemloft.net>
Date:	Thu, 02 Jun 2011 00:10:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	julia@...u.dk
Cc:	joe@...ches.com, wg@...ndegger.com,
	kernel-janitors@...r.kernel.org, socketcan-core@...ts.berlios.de,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, wharms@....de
Subject: Re: [PATCH 4/10] drivers/net/can/flexcan.c: add missing clk_put

From: Julia Lawall <julia@...u.dk>
Date: Thu, 2 Jun 2011 07:48:50 +0200 (CEST)

> From: Julia Lawall <julia@...u.dk>
> 
> The failed_get label is used after the call to clk_get has succeeded, so it
> should be moved up above the call to clk_put.
> 
> The failed_req labels doesn't do anything different than failed_get, so
> delete it.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
 ...
> Signed-off-by: Julia Lawall <julia@...u.dk>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/