linux-kernel - Re: [PATCH] mtd: pxa3xx_nand: remove unused variable 'mtd'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTinfOmA1cW6Ktuka1NS+7D0RhFqMvw@mail.gmail.com>
Date:	Fri, 3 Jun 2011 15:00:18 +0200
From:	Daniel Mack <zonque@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Haojian Zhuang <haojian.zhuang@...vell.com>,
	Artem Bityutskiy <Artem.Bityutskiy@...ia.com>,
	Eric Miao <eric.y.miao@...il.com>,
	linux-mtd@...ts.infradead.org, Lei Wen <adrian.wenl@...il.com>
Subject: Re: [PATCH] mtd: pxa3xx_nand: remove unused variable 'mtd'

(cc Lei Wen)

On Fri, Jun 3, 2011 at 9:34 AM, Axel Lin <axel.lin@...il.com> wrote:
> Remove unused variable 'mtd' to eliminate below warning.
>
>  CC      drivers/mtd/nand/pxa3xx_nand.o
> drivers/mtd/nand/pxa3xx_nand.c: In function 'pxa3xx_nand_suspend':
> drivers/mtd/nand/pxa3xx_nand.c:1167: warning: unused variable 'mtd'
> drivers/mtd/nand/pxa3xx_nand.c: In function 'pxa3xx_nand_resume':
> drivers/mtd/nand/pxa3xx_nand.c:1180: warning: unused variable 'mtd'
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Lei, I had the same patch queued up on my side and dropped it now. Can
you apply this one?

Thanks,
Daniel



> ---
>  drivers/mtd/nand/pxa3xx_nand.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
> index 1fb3b3a..5cae8ae 100644
> --- a/drivers/mtd/nand/pxa3xx_nand.c
> +++ b/drivers/mtd/nand/pxa3xx_nand.c
> @@ -1164,7 +1164,6 @@ static int pxa3xx_nand_probe(struct platform_device *pdev)
>  static int pxa3xx_nand_suspend(struct platform_device *pdev, pm_message_t state)
>  {
>        struct pxa3xx_nand_info *info = platform_get_drvdata(pdev);
> -       struct mtd_info *mtd = info->mtd;
>
>        if (info->state) {
>                dev_err(&pdev->dev, "driver busy, state = %d\n", info->state);
> @@ -1177,7 +1176,6 @@ static int pxa3xx_nand_suspend(struct platform_device *pdev, pm_message_t state)
>  static int pxa3xx_nand_resume(struct platform_device *pdev)
>  {
>        struct pxa3xx_nand_info *info = platform_get_drvdata(pdev);
> -       struct mtd_info *mtd = info->mtd;
>
>        nand_writel(info, NDTR0CS0, info->ndtr0cs0);
>        nand_writel(info, NDTR1CS0, info->ndtr1cs0);
> --
> 1.7.4.1
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/