[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1307111215.3667.53.camel@gandalf.stny.rr.com>
Date: Fri, 03 Jun 2011 10:26:55 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Jiri Olsa <jolsa@...hat.com>
Cc: fweisbec@...il.com, mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] tracing, function, graph: Fixies for field display
On Fri, 2011-06-03 at 16:19 +0200, Jiri Olsa wrote:
> hi,
>
> this patchset contains some fixies of trace output for
> function and function_graph tracers.
>
> attached patches:
> 1/5 tracing, function_graph: Remove dependency of abstime and duration fields on latency
> 2/5 tracing, function_graph: Merge overhead and duration display functions
> 3/5 tracing, function: Fix trace header to follow context-info option
> 4/5 tracing, function_graph: Remove lock-depth from latency trace
> 5/5 tracing, function_graph: Add context-info support for function_graph tracer
Hi Jiri,
Thanks for these patches. But could you change the change logs to show
the problems that you see. Just a description does not express what is
really wrong. Basically add a:
This is what it looked like before:
....
This is what it looks like now:
....
That way it is obvious what the patches do. I'll test these anyway to
get a before and after, but it is helpful to see it in the change log.
Thanks,
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists