linux-kernel - Re: [PATCH] MTD: pxa3xx_nand: Fix blank page ECC mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jun 2011 23:04:39 +0800
From:	Lei Wen <adrian.wenl@...il.com>
To:	Daniel Mack <zonque@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	David Woodhouse <David.Woodhouse@...el.com>,
	Lei Wen <leiwen@...vell.com>,
	Haojian Zhuang <haojian.zhuang@...vell.com>, stable@...nel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] MTD: pxa3xx_nand: Fix blank page ECC mismatch

On Fri, Jun 3, 2011 at 9:03 PM, Daniel Mack <zonque@...il.com> wrote:
> This bug was introduced in f8155a40 ("mtd: pxa3xx_nand: rework irq
> logic") and causes the PXA3xx NAND controller fail to operate with NAND
> flash that has empty pages. According to the comment in this block, the
> hardware controller will report a double-bit error for empty pages,
> which can and must be ignored.
>
> This patch restores the original behaviour of the driver.
>
> Signed-off-by: Daniel Mack <zonque@...il.com>
> Cc: Lei Wen <leiwen@...vell.com>
> Cc: Haojian Zhuang <haojian.zhuang@...vell.com>
> Cc: David Woodhouse <David.Woodhouse@...el.com>
> Cc: stable@...nel.org
> ---
>  drivers/mtd/nand/pxa3xx_nand.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
> index 0c6ed72..60167d1 100644
> --- a/drivers/mtd/nand/pxa3xx_nand.c
> +++ b/drivers/mtd/nand/pxa3xx_nand.c
> @@ -687,6 +687,8 @@ static int pxa3xx_nand_read_page_hwecc(struct mtd_info *mtd,
>                 * OOB, ignore such double bit errors
>                 */
>                if (is_buf_blank(buf, mtd->writesize))
> +                       info->retcode = ERR_NONE;
> +               else
>                        mtd->ecc_stats.failed++;
>        }
>
> --
> 1.7.5.1
>

Acked-by: Lei Wen <leiwen@...vell.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/