lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Jun 2011 23:32:37 +0800 From: Américo Wang <xiyou.wangcong@...il.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: linux-cris-kernel@...s.com, LKML <linux-kernel@...r.kernel.org>, Geert Uytterhoeven <geert@...ux-m68k.org>, Mikael Starvik <starvik@...s.com>, Jesper Nilsson <jesper.nilsson@...s.com> Subject: Re: [Patch] cris: add missing declaration of kgdb_init() and breakpoint() On Fri, Jun 3, 2011 at 1:21 AM, Andrew Morton <akpm@...ux-foundation.org> wrote: > On Thu, 2 Jun 2011 22:31:41 +0800 Am__rico Wang <xiyou.wangcong@...il.com> wrote: > >> On Wed, Jun 01, 2011 at 03:16:18PM -0700, Andrew Morton wrote: >> >On Sun, 22 May 2011 22:42:56 +0800 >> >Am__rico Wang <xiyou.wangcong@...il.com> wrote: >> > >> >> --- a/arch/cris/arch-v10/kernel/irq.c >> >> +++ b/arch/cris/arch-v10/kernel/irq.c >> >> @@ -20,6 +20,9 @@ >> >> #define crisv10_mask_irq(irq_nr) (*R_VECT_MASK_CLR = 1 << (irq_nr)); >> >> #define crisv10_unmask_irq(irq_nr) (*R_VECT_MASK_SET = 1 << (irq_nr)); >> >> >> >> +extern void kgdb_init(void); >> >> +extern void breakpoint(void); >> > >> >They should be declared in a header file, please. >> >arch/cris/arch-v32/kernel/irq.c has a private declaration of >> >kgdb_init(), too. >> > >> >> Yeah, but I don't find a proper header to declare them. > > Don't be afraid to create a new file! If that's the appropriate thing > to do, it's probably the correct thing to do. > You are right... > > I'd follow the herd and create arch/cris/include/asm/kgdb.h. > Or maybe arch/cris/include/arch-v10/arch/kgdb.h is better? Anyway, since you already took the patch, I will send a delta patch. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists