linux-kernel - Re: [PATCH] gpio: Samsung: make Kconfig options def

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110603182545.GH15616@ponder.secretlab.ca>
Date:	Fri, 3 Jun 2011 12:25:45 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	kyungmin.park@...sung.com
Subject: Re: [PATCH] gpio: Samsung: make Kconfig options def_bool

On Thu, Jun 02, 2011 at 10:14:58AM -0700, H Hartley Sweeten wrote:
> The Samsung GPIO drivers are always built-in when the relevant
> platform is selected.  Change the Kconfig symbol to def_bool y
> dependant on the platform.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Acked-by: Kyungmin Park <kyungmin.park@...sung.com>
> Cc: Grant Likely <grant.likely@...retlab.ca>

Patch doesn't apply on mainline.  Linus already fixed up some stuff.

g.

> 
> ---
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 18c0b31..2e3cd11 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -87,32 +87,20 @@ config GPIO_IT8761E
>  	  Say yes here to support GPIO functionality of IT8761E super I/O chip.
>  
>  config GPIO_EXYNOS4
> -	bool "Samsung Exynos4 GPIO library support"
> -	default y
> -	depends on ARM && CPU_EXYNOS4210
> -	help
> -	  Say yes here to support Samsung Exynos4 series SoCs GPIO library
> +	def_bool y
> +	depends on CPU_EXYNOS4210
>  
>  config GPIO_PLAT_SAMSUNG
> -	bool "Samsung SoCs GPIO library support"
> -	default y
> -	depends on ARM && SAMSUNG_GPIOLIB_4BIT
> -	help
> -	  Say yes here to support Samsung SoCs GPIO library
> +	def_bool y
> +	depends on SAMSUNG_GPIOLIB_4BIT
>  
>  config GPIO_S5PC100
> -	bool "Samsung S5PC100 GPIO library support"
> -	default y
> -	depends on ARM && CPU_S5PC100
> -	help
> -	  Say yes here to support Samsung S5PC100 SoCs GPIO library
> +	def_bool y
> +	depends on CPU_S5PC100
>  
>  config GPIO_S5PV210
> -	bool "Samsung S5PV210/S5PC110 GPIO library support"
> -	default y
> -	depends on ARM && CPU_S5PV210
> -	help
> -	  Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
> +	def_bool y
> +	depends on CPU_S5PV210
>  
>  config GPIO_PL061
>  	bool "PrimeCell PL061 GPIO support"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/