linux-kernel - Re: [PATCH 4/8] mfd: twl6040: Add initial support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jun 2011 19:44:26 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	"Krishnamoorthy, Balaji T" <balajitk@...com>
Cc:	"Girdwood, Liam" <lrg@...com>, Tony Lindgren <tony@...mide.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"Lopez Cruz, Misael" <misael.lopez@...com>,
	Jorge Eduardo Candelaria <jorge.candelaria@...com>,
	Margarita Olaya Cabrera <magi.olaya@...com>
Subject: Re: [PATCH 4/8] mfd: twl6040: Add initial support

On Wednesday 01 June 2011 16:47:21 Krishnamoorthy, Balaji T wrote:
> > +int twl6040_reg_read(struct twl6040 *twl6040, unsigned int reg)
> > +{
> > +       int ret;
> > +       u8 val = 0;
> > +
> > +       mutex_lock(&twl6040->io_mutex);
> > +       ret = twl_i2c_read_u8(TWL_MODULE_AUDIO_VOICE, &val, reg);
> 
> Can this dependency on twl_i2c_[read/write] be removed,
> Since TWL6040 is a separate IC which can get its own i2c_client in
> twl6040-core.c and
> create its own mfd devices like vibra, audio-codec ... while creating
> twl6040-core.c

You are right, twl6040 is separate IC.
I'll take a look how it can be separated from the twl-core (twl6030).

Thanks for noticing this, 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/