linux-kernel - Re: [PATCH] lib: introduce strdup_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DE92DF1.4090203@freescale.com>
Date:	Fri, 3 Jun 2011 13:54:41 -0500
From:	Timur Tabi <timur@...escale.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
CC:	<alan@...rguk.ukuu.org.uk>, <linux-kernel@...r.kernel.org>,
	<scottwood@...escale.com>, <akpm@...ux-foundation.org>
Subject: Re: [PATCH] lib: introduce strdup_from_user

Alexey Dobriyan wrote:
> It leaks first allocation if second one fails.
> 
> Come on.

Ugh, sorry.  In my defense, I am suffering from allergies at the moment.

> Show you user in driver, maybe what we're discussing is moot.

The driver and discussion on it can be found here:

http://patchwork.ozlabs.org/patch/98233/

Search for "ioctl_dtprop" to see its usage.

In summary, I'm copying a user-space string into a kmalloc'd buffer so that it's
physically contiguous and I can get the physical address for it.  I then call
our hypervisor and give it the physical address.  This is why I want a copy of
the string in a buffer allocated via kmalloc.

-- 
Timur Tabi
Linux kernel developer at Freescale

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/