linux-kernel - Re: [PATCH] x86-64: Prevent gcc from optimizing away venosys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jun 2011 23:37:13 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Dave Anderson <anderson@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	mingo@...e.hu, jstancek@...hat.com
Subject: Re: [PATCH] x86-64: Prevent gcc from optimizing away venosys_1()

On Fri, Jun 03, 2011 at 05:32:06PM -0400, Dave Anderson wrote:
> 
> 
> ----- Original Message -----
> > >  	return 0;
> > >  }
> > >
> > > -static long __vsyscall(3) venosys_1(void)
> > > +long __vsyscall(3) venosys_1(void)
> > 
> > Better add a __used too. Otherwise it can be optimized out again
> > in some builds e.g. when someone enables gc-sections for the linker.
> 
> Considering that all of the vsyscall prototypes have this attribute:
> 
> #define __vsyscall(nr) \
>                 __attribute__ ((unused, __section__(".vsyscall_" #nr))) notrace
> 
> How would any of them work?

unused is just to prevent warnings I think. used stops the optimizer
from throwing it away.

It would make more sense to drop the unused and add an used.  I think
used prevents the warnings too.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/