linux-kernel - Re: [PATCH] Fix compiler warning in ftrace.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B4B144EDA1BA4138AFAC732D06C60F8B@WWW67E861F6858>
Date:	Fri, 3 Jun 2011 12:52:59 +0800
From:	"Guowen Li" <guowen.li.linux@...il.com>
To:	"Steven Rostedt" <rostedt@...dmis.org>
Cc:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix compiler warning in ftrace.c

Thank you for pointing them out, i will be careful next time. :)

Signed-off-by: Guowen Li <guowen.li.linux@...il.com>
----- Original Message ----- 
From: "Steven Rostedt" <rostedt@...dmis.org>
To: "GuoWen Li" <guowen.li.linux@...il.com>
Cc: <linux-kernel@...r.kernel.org>
Sent: Friday, June 03, 2011 10:50 AM
Subject: Re: [PATCH] Fix compiler warning in ftrace.c


> Couple of things:
> 
> On Wed, 2011-06-01 at 19:18 +0800, GuoWen Li wrote:
>> kernel/trace/ftrace.c: In function ‘ftrace_regex_write.clone.15’:
>> kernel/trace/ftrace.c:2743:6: warning: ‘ret’ may be used uninitialized in this 
>> function
>> 
>> Signed-off-by: GuoWen Li
> 
> Please add your mail address to your SOB. (I'll fix it)
> 
>> ---
>>  kernel/trace/ftrace.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
>> index 1ee417f..204b3eb 100644
>> --- a/kernel/trace/ftrace.c
>> +++ b/kernel/trace/ftrace.c
>> @@ -2740,7 +2740,7 @@ static int ftrace_process_regex(struct ftrace_hash 
>> *hash,
>>  {
>>         char *func, *command, *next = buff;
>>         struct ftrace_func_command *p;
>> -       int ret;
>> +       int ret = -EINVAL;
> 
> This patch has horrible white space issues. (I fixed it)
> 
> -- Steve
> 
> 
>>  
>>         func = strsep(&next, ":");
> 
> 
>