| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Jun 2011 08:52:01 +0100 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Shawn Guo <shawn.guo@...aro.org> Cc: linux-kernel@...r.kernel.org, arnd@...db.de, patches@...aro.org, grant.likely@...retlab.ca, kernel@...gutronix.de, olof@...om.net, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v2 0/4] Move plat-mxc gpio driver into drivers/gpio On Thu, Jun 02, 2011 at 11:33:48AM +0800, Shawn Guo wrote: > arch/arm/plat-mxc/gpio.c | 361 ------------------- > drivers/gpio/gpio-mxc.c | 433 +++++++++++++++++++++++ I'm wondering why just moving this driver into drivers/gpio has resulted in it growing by 72 lines - and it's not clear from the diffs why that is because of the way they're broken up. Would it not be better to have the first patch to merely move arch/arm/plat-mxc/gpio.c to drivers/gpio/gpio-mxc.c, making whatever config changes are necessary. Then subsequent patches should change drivers/gpio/gpio-mxc.c as required - which means we can see what changes are being made. As the series currently stands, from the review point of view it's effectively adding an entirely new driver, converting everything over to it, and then deleting the old. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists