linux-kernel - Re: [PATCH 3/8] MFD: twl4030-audio: Rename platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110603080819.GK8696@atomide.com>
Date:	Fri, 3 Jun 2011 11:08:22 +0300
From:	Tony Lindgren <tony@...mide.com>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	"Girdwood, Liam" <lrg@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH 3/8] MFD: twl4030-audio: Rename platform data

* Peter Ujfalusi <peter.ujfalusi@...com> [110602 09:11]:
> On Wednesday 01 June 2011 16:38:23 Tony Lindgren wrote:
> > But you could easily remove all the board specific struct
> > twl4030_codec_data and struct twl4030_codec_audio_data entries by adding a
> > default audio init option to omap_pmic_init for the common configuration.
> 
> Yeah, I can grep in the board files, and see what is the most common 
> configuration
> 
> > How about something like:
> > 
> > void omap_pmic_init(int bus, u32 clkrate, const char *pmic_type, int
> > pmic_irq, struct twl4030_platform_data *pmic_data, u32 flags);
> 
> common-board-devices.c has omap_pmic_init, but without the flags.
> 
> > Where flags would be TWL_BOARD_HAS_DEFAULT_CODEC etc, and if the entry in
> > pmic_data is NULL, just use the default configuration. I think you already
> > have the clkrate there?
> 
> I'll take a look, should we have new file specifically for twl, or should I 
> extend the common-board-devices.c with the twl related things? IMHO a new file 
> might be better, since the full twl config might be quite big.

Yeah if it gets big then a separate file is better. Also, if we have
a common init function for twl, then it's easy to add the board specific
device tree initialization to that too and just leave out the calls to
omap_pmic_init from board-*.c files.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/