linux-kernel - Re: [PATCH] drivers/usb/gadget: add missing kfree calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110604235449.6a00218c@kvasir>
Date:	Sat, 4 Jun 2011 23:54:49 +0200
From:	Andre Bartke <andre.bartke@...glemail.com>
To:	"Michal Nazarewicz" <mina86@...a86.com>
Cc:	"Andre Bartke" <andre.bartke@...glemail.com>, gregkh@...e.de,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/usb/gadget: add missing kfree calls

On Sat, 04 Jun 2011 23:35:16 +0200
"Michal Nazarewicz" <mina86@...a86.com> wrote:

> On Sat, 04 Jun 2011 21:34:54 +0200, Andre Bartke  
> <andre.bartke@...glemail.com> wrote:
> > diff --git a/drivers/usb/gadget/rndis.c b/drivers/usb/gadget/rndis.c
> > @@ -700,6 +701,7 @@ static int rndis_reset_response(int configNr,  
> > rndis_reset_msg_type *buf)
> >  	resp->AddressingReset = cpu_to_le32(1);
> > 	params->resp_avail(params->v);
> > +	kfree(r);
> >  	return 0;
> >  }
> 
> Have you tested this?  It does not look right to me.
> rndis_add_response() allocates memory and puts the request on a
> list.  It is later freed in rndis_free_response().
> 

Nope, the only way I can test this is a build - which it does.
You might be right though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/