linux-kernel - Re: [PATCH] mm: Fix wrong kunmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1307159669.31814.3.camel@gandalf.stny.rr.com>
Date:	Fri, 03 Jun 2011 23:54:29 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Hugh Dickins <hughd@...gle.com>, Mel Gorman <mel@....ul.ie>
Subject: Re: [PATCH] mm: Fix wrong kunmap_atomic() pointer

On Fri, 2011-06-03 at 23:37 -0400, Steven Rostedt wrote:

> The problem came in d16dfc55 where it introduced a "break;" from the
> while loop. This alone did not seem to easily trigger the bug. But the
> modifications made by e303297e6 caused that "break;" to be hit on the
> first iteration, before the pte++.
> 
> The pte not being incremented will now cause pte_unmap_unlock(pte - 1)
> to be pointing to the previous page. This will cause the wrong page to
> be unmapped, and also trigger the warning above.

Note, just to prove this was the case, by adding a few trace_printks()
and a tracing_off() when the bug hit, I found the following:

           <...>-93    [000]    65.630994: unmap_vmas: enter addr=0xa00000 end=0xa53000
           <...>-93    [000]    65.630995: unmap_vmas: pte=fffb9000
           <...>-93    [000]    65.630996: unmap_vmas: loop pte=fffb9000 addr=0xa00000
           <...>-93    [000]    65.630996: unmap_vmas: force flush!
           <...>-93    [000]    65.630997: unmap_vmas: end loop pte=fffb9000
           <...>-93    [000]    65.630997: unmap_vmas: unlock pte-1=fffb8ff8

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/