linux-kernel - Re: [PATCH 1/5] staging: et131x: et1310_address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110605201426.15570403@lxorguk.ukuu.org.uk>
Date:	Sun, 5 Jun 2011 20:14:26 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mark Einon <mark.einon@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, o.hartmann@...ovital.com
Subject: Re: [PATCH 1/5] staging: et131x: et1310_address_map.h checkpatch
 fixes

> +union RXMAC_WOL_SA_LO_t {
>  	u32 value;
>  	struct {
>  #ifdef _BIT_FIELDS_HTOL
> @@ -716,13 +716,13 @@ typedef union _RXMAC_WOL_SA_LO_t {
>  		u32 sa3:8;	/* bits 24-31 */

Pleease don't do it this way. If you look at the code we've been
systematically working through the unions turning them into definitions
in comments and sometimes bitmasks because almost none of the bit field
stuff is useful in these things anyway. Removing the typedefs without
doing it just muddles up what has and hasn't been done.

In fact in many cases the .value bit is the only bit used

Please keep to that style of describing the bits and knocking out fields
where it doesn't make sense.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/